> On April 19, 2019, 3:27 p.m., Na Li wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/LineageVertex.java > > Lines 27 (patched) > > <https://reviews.apache.org/r/70505/diff/1/?file=2140262#file2140262line27> > > > > can you make the type to be Integer? So it is consistent with the id > > type ion LineageEdge "private List<Integer> sources;" > > Xinran Tinney wrote: > Thre are 3 elements in LieageVetext > private String id; > private String vertexType; > private String vertexId; > > The one in private List<Integer> sources is using the first one "id", I > can not make vertexId an Integer because it is not a number. e.g. > "vertexId":"db_1.view_1.count" > > Xinran Tinney wrote: > Do you mean the change "id" to Integer?
sorry. I meant "id" should be Integer. vertexId should be String - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70505/#review214761 ----------------------------------------------------------- On April 18, 2019, 8:33 p.m., Xinran Tinney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70505/ > ----------------------------------------------------------- > > (Updated April 18, 2019, 8:33 p.m.) > > > Review request for atlas and Na Li. > > > Repository: atlas > > > Description > ------- > > the code is implemented in Java. > > 1) It takes Impala file location and file name prefix as input. > 2) It reads its own record-keeping file to get the offset of the Impala file > it has already read. Then read the new records from Impala file, update the > record-keeping file to append the new offset of the Impala file. > 3) It parses the new records from Impala file into internal data structure as > output. > 4) If the Impala file name has changed, start a new file for record-keeping > and remove the old record-keeping file. > 5) Implemented unit test to verify the behavior. > > > Diffs > ----- > > addons/impala-bridge/impala1.txt PRE-CREATION > addons/impala-bridge/impala2.txt PRE-CREATION > addons/impala-bridge/pom.xml PRE-CREATION > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/ImpalaBridge.java > PRE-CREATION > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/LineageEdge.java > PRE-CREATION > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/LineageQuery.java > PRE-CREATION > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/LineageVertex.java > PRE-CREATION > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/bridge/TestImpalaBridge.java > PRE-CREATION > pom.xml 76341388b > > > Diff: https://reviews.apache.org/r/70505/diff/1/ > > > Testing > ------- > > unit testing and mvn clean install -DskipTests > > > Thanks, > > Xinran Tinney > >
