----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70536/#review214855 -----------------------------------------------------------
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java Lines 110 (patched) <https://reviews.apache.org/r/70536/#comment301089> It is not obvious here why you do it? Can you add comment that driver using this configuration will be used to test HiveHook, so HMS hook is not configurated? addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java Line 131 (original), 137 (patched) <https://reviews.apache.org/r/70536/#comment301090> add comment addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java Line 138 (original), 146 (patched) <https://reviews.apache.org/r/70536/#comment301091> to make the logic clear, you can make runCommand(String cmd) as abstract function. And the child class implement it. For example, HiveHookIT implements with driver , and HiveMetastoreHookIT implements with driverWithoutContext. - Na Li On April 24, 2019, 1:34 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70536/ > ----------------------------------------------------------- > > (Updated April 24, 2019, 1:34 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, Na > Li, Le Ma, Madhan Neethiraj, Nikhil Bonte, and Nixon Rodrigues. > > > Bugs: ATLAS-3157 > https://issues.apache.org/jira/browse/ATLAS-3157 > > > Repository: atlas > > > Description > ------- > > Add Integration tests for Hive metastore hook > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java > c8c53c473 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 677043a01 > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveMetastoreHookIT.java > PRE-CREATION > addons/hive-bridge/src/test/resources/hive-site.xml 4605ae322 > > > Diff: https://reviews.apache.org/r/70536/diff/1/ > > > Testing > ------- > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1048/console > > > Thanks, > > Sarath Subramanian > >
