----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70543/#review214868 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorService.java Line 56 (original), 56 (patched) <https://reviews.apache.org/r/70543/#comment301149> If no order is specified, the default seems to be Integer.MAX_VALUE (looking at org.springframework.core.annotation.Order). If this is true, it might be safer to leave out "@Order" annotation here. If you decide to leave "@Order" annotation in place, please add a comment that this service should be the last one. - Madhan Neethiraj On April 24, 2019, 10:42 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70543/ > ----------------------------------------------------------- > > (Updated April 24, 2019, 10:42 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3168 > https://issues.apache.org/jira/browse/ATLAS-3168 > > > Repository: atlas > > > Description > ------- > > PatchService should implement _ActiveStateChangeHandler_ so that it gets > events from ZK electoral election. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 6e8dbe9ad > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > c57f8e3c7 > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchService.java > fc2128529 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > c3356edd4 > > server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java > c38e53c37 > > webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorService.java > 10081ac9c > > > Diff: https://reviews.apache.org/r/70543/diff/2/ > > > Testing > ------- > > **Functional tests** > Verified in HA environment with kerberos and ssl enabled. > > **Unit tests** > Existing tests. > > > Thanks, > > Ashutosh Mestry > >
