----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70584/#review215003 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On May 2, 2019, 6:26 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70584/ > ----------------------------------------------------------- > > (Updated May 2, 2019, 6:26 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, Le > Ma, Nikhil Bonte, Nixon Rodrigues, Sarath Subramanian, Sharmadha Sainath, and > Umesh Padashetty. > > > Bugs: ATLAS-3187 > https://issues.apache.org/jira/browse/ATLAS-3187 > > > Repository: atlas > > > Description > ------- > > While populating legacyAttribute from its corresponding > relationshipAttribute, only objects with ACTIVE relationship-edge were > included. This caused the deleted contained entities to be skipped. Updated > this logic to skip only ACTIVE entities with DELETED relationship-edge (like > a hive_table moved from one-db to another). > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 3e1e023e9 > > > Diff: https://reviews.apache.org/r/70584/diff/2/ > > > Testing > ------- > > - verified that entity-get on a deleted hive_table includes all its columns > as well > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1072/ > > > Thanks, > > Madhan Neethiraj > >
