----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70588/#review215012 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 3, 2019, 4:36 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70588/ > ----------------------------------------------------------- > > (Updated May 3, 2019, 4:36 a.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Bugs: ATLAS-3188 > https://issues.apache.org/jira/browse/ATLAS-3188 > > > Repository: atlas > > > Description > ------- > > insert into <table> values (<values>) is triggering messages in ATLAS_HOOK > topic. Due to this, Atlas is reporting the operations in Audits. > > Ideally, insert queries should not generate any messages in ATLAS_HOOK since > they do not play any role in lineage > > Inserting 100 rows in a table is generating 100 messages in the kafka topic. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java > 54cd48f04 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java > f378d8457 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java > cdb4cd218 > > > Diff: https://reviews.apache.org/r/70588/diff/2/ > > > Testing > ------- > > validated that "insert into values" query doesn't create hive_process entities > > > Thanks, > > Sarath Subramanian > >
