-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70623/#review215193
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Line 107 (original), 102 (patched)
<https://reviews.apache.org/r/70623/#comment301745>

    What does "version=12" mean? This detail doesn't seem be included in the 
zink (i.e. exported data).


- Madhan Neethiraj


On May 10, 2019, 6:19 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70623/
> -----------------------------------------------------------
> 
> (Updated May 10, 2019, 6:19 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-3176
>     https://issues.apache.org/jira/browse/ATLAS-3176
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> Reconcile use of _addToExport_ order with _addToSink_.
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  9fdfb0f50 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ZipSource.java 
> bf23f819a 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java
>  df9e28040 
> 
> 
> Diff: https://reviews.apache.org/r/70623/diff/3/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> 
> Existing tests.
> 
> **Functional tests**
> Executed export-import-export-compare test.
> 
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1094/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Reply via email to