----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215344 -----------------------------------------------------------
Sorry for the last deal, we're discussing to remove attribute `durationMs` as we found SAC has no way to fill the right value. (The value is query-based whereas `spark_process` model is application-based.) Could we hold off this to early next week as we will update the PR here https://github.com/hortonworks-spark/spark-atlas-connector/pull/249 and merge shortly? - Jungtaek Lim On 5 17, 2019, 5:47 오후, Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated 5 17, 2019, 5:47 오후) > > > Review request for atlas, Ankur Gupta, Arun Mahadevan, Ashutosh Mestry, > Jungtaek Lim, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1100-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/4/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
