-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70701/#review215478
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On May 22, 2019, 1:54 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70701/
> -----------------------------------------------------------
> 
> (Updated May 22, 2019, 1:54 p.m.)
> 
> 
> Review request for atlas and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The code under impala-bridge module is under the folder 
> "addons/impala-bridge/src/main/java/org.apache.atlas.impala/", they should be 
> put under the folder 
> "addons/impala-bridge/src/main/java/org/apache/atlas/impala/" to follow the 
> convention.
> 
> 
> Diffs
> -----
> 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java
>  7c9abc8 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/AtlasImpalaHookContext.java
>  88faace 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaHook.java
>  2afb4eb 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaIdentifierParser.java
>  b9d6cbb 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaLineageHook.java
>  232a569 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaOperationParser.java
>  b9dd894 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/BaseImpalaEvent.java
>  63c5f87 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java
>  0dc520c 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaDataType.java
>  10ce448 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaDependencyType.java
>  892ee9b 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaNode.java
>  a3ddf53 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaOperationType.java
>  a893b88 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaQuery.java
>  27bdc72 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/ImpalaVertexType.java
>  8ec3f85 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageEdge.java
>  251507e 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageVertex.java
>  0a664fc 
>   
> addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageVertexMetadata.java
>  0bd236d 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaHook.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaOperationParser.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDataType.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDependencyType.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaNode.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaOperationType.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaQuery.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaVertexType.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/LineageEdge.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/LineageVertex.java
>  PRE-CREATION 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/LineageVertexMetadata.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70701/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to