----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70606/#review215605 -----------------------------------------------------------
Ship it! Ship It! - Sridhar K On May 21, 2019, 12:06 a.m., Yu-Hsin Shih wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70606/ > ----------------------------------------------------------- > > (Updated May 21, 2019, 12:06 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2901 > https://issues.apache.org/jira/browse/ATLAS-2901 > > > Repository: atlas > > > Description > ------- > > 1. Allow Unicode in classification name and follow the original regex rule as > possible as we can. > 2. Update the error message to reflect that the rule allows space. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java c04f561c1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java > dd020d183 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70606/diff/2/ > > > Testing > ------- > > Manual tested by using Chinese characters in both Classification and its > attribute. > Add unit test cases. > > > File Attachments > ---------------- > > Classification def > > https://reviews.apache.org/media/uploaded/files/2019/05/07/f629f9db-e858-4f11-a018-5d91aba0a286__Screen_Shot_2019-05-07_at_1.50.01_PM.png > Entity Association > > https://reviews.apache.org/media/uploaded/files/2019/05/07/d36894df-5acf-4227-b591-11029bf3f009__Screen_Shot_2019-05-07_at_1.49.44_PM.png > > > Thanks, > > Yu-Hsin Shih > >
