ZepHakase22 commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-497831594 @mneethiraj - I didn't understand if you propose to add new REST APIs by type /enumdef /servicetype/hive for example) but use the /typedefs code like /typedefs?serviceType=hive&&type=enum or not to add just these REST APIs leaving what the REST API already does with the generic parameters. In my opinion and experience the types are loaded once, they are not many and therefore they occupy little memory while, typically, they are read many times; the introduction of the serviceType cache greatly facilitates these readings with respect to using the cache of only names and guid in terms of cycles. Using predicates will also be very elegant but there are more an more cycles that must be done to aggregate the set of entities that make up the serviceType. For which I strongly advocate a map by serviceType in typeRegistry. Finally, I think we can change the typeRegistry to improve it, if the code works fine.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
