----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70812/#review215762 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On June 7, 2019, 11:13 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70812/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 11:13 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, > Sridhar K, Le Ma, Mehul Parikh, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, > and Sarath Subramanian. > > > Bugs: ATLAS-3269 > https://issues.apache.org/jira/browse/ATLAS-3269 > > > Repository: atlas > > > Description > ------- > > added "is-null-or-empty" in-memory filter and updated search-processors to > use this filter instead of "is-null" filter > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 1cd507c3b > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > c4b5ffb12 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > 38de885cf > > > Diff: https://reviews.apache.org/r/70812/diff/1/ > > > Testing > ------- > > - verified that search with query=hive_table, classification=_NOT_CLASSIFIED > returns all hive_table entities having no classifications > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1189/ > > > Thanks, > > Madhan Neethiraj > >
