----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70880/#review215958 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On June 18, 2019, 3:38 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70880/ > ----------------------------------------------------------- > > (Updated June 18, 2019, 3:38 p.m.) > > > Review request for atlas, madhan and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > The column name in Impala lineage record may not contain its database name > and its table name. > > To get its its database name and its table name, we should use the metadata > in a vertex, not assuming column name contains its database name and its > table name. > > > Diffs > ----- > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java > 5b5f05a > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java > 6d65ae0 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > d437ba2 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 6908191 > > addons/impala-bridge/src/test/resources/impalaCreateTableAsSelectVertexIdNoTableName.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70880/diff/1/ > > > Testing > ------- > > add new test case > ImpalaLineageToolIT.testCreateTableAsSelectVertexIdNoTableNameFromFile for > this scenario > > > Thanks, > > Na Li > >
