----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70913/#review216238 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 723 (patched) <https://reviews.apache.org/r/70913/#comment303370> getAttribute(attributeName) could be null - if non-existing attribute was specified in the template. Please handle this case (i.e. log a warning, ignore and continue), to avoid NPE. - Madhan Neethiraj On June 28, 2019, 10:37 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70913/ > ----------------------------------------------------------- > > (Updated June 28, 2019, 10:37 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes > > > Diffs > ----- > > addons/models/1000-Hadoop/1030-hive_model.json > 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > d9ae9e36773146fad652a1e28fc8822bae5c8557 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 254eee4c9d18ab87a8862ce479fc2274227c7c29 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > 3c53c02b48747515217c9327c98209a48ee84237 > > > Diff: https://reviews.apache.org/r/70913/diff/6/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Merryle Wang > >
