----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71064/#review216579 -----------------------------------------------------------
Fix it, then Ship it! rebase patch addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java Line 226 (original), 226 (patched) <https://reviews.apache.org/r/71064/#comment303787> set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_column_families" addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java Line 406 (original), 406 (patched) <https://reviews.apache.org/r/71064/#comment303788> set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_namespace" addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java Line 465 (original), 465 (patched) <https://reviews.apache.org/r/71064/#comment303790> set relationship attribute to AtlasRelatedObjectId object with relationshipName - "hbase_table_column_families" addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java Line 425 (original), 425 (patched) <https://reviews.apache.org/r/71064/#comment303792> change cfIDs to AtlasRelatedObjectIds with relationship name - "hbase_table_column_families" addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java Line 542 (original), 542 (patched) <https://reviews.apache.org/r/71064/#comment303793> same here addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java Line 571 (original), 571 (patched) <https://reviews.apache.org/r/71064/#comment303794> update to related object id - Sarath Subramanian On July 12, 2019, 6 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71064/ > ----------------------------------------------------------- > > (Updated July 12, 2019, 6 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3326 Update Hbase hook/bridge to use relationship attribute > > > Diffs > ----- > > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > 1825cd2 > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java > 1765c18 > > > Diff: https://reviews.apache.org/r/71064/diff/1/ > > > Testing > ------- > > Steps done for updating > 1. Disable hbase-hook from Ambari. > 2. Create table in hbase. > 3. Check whether table entity is created in Atlas side or not.(It should not > be created) > 4. Run script import-hbsae.sh > 5. Check again in Atlas side, hbase table and namespace entities are created > with relationship. > > > Thanks, > > Mandar Ambawane > >
