> On July 18, 2019, 8:10 a.m., Sridhar K wrote:
> > Ship It!

Thanks for fixing it.


- Sridhar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71089/#review216713
-----------------------------------------------------------


On July 17, 2019, 6:45 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71089/
> -----------------------------------------------------------
> 
> (Updated July 17, 2019, 6:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon 
> Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3338
>     https://issues.apache.org/jira/browse/ATLAS-3338
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> updated resolveIndexFieldName() to check the attribute instance in super-type 
> i.e. the type where the attribute is defined-in; only when this instance 
> doesn't have index-field name set, graph API is called to retrieve the value
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  95ae5049e 
> 
> 
> Diff: https://reviews.apache.org/r/71089/diff/2/
> 
> 
> Testing
> -------
> 
> - manaully verified that only one call is made to graph API during 
> type-system initialization/update
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1271
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to