----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71129/#review216788 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java Lines 115 (patched) <https://reviews.apache.org/r/71129/#comment304013> processedMessageCount should be incremented irrespective of success or not - similar to overall count at line #86 above. - Madhan Neethiraj On July 22, 2019, 12:35 p.m., Saqeeb Shaikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71129/ > ----------------------------------------------------------- > > (Updated July 22, 2019, 12:35 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3344 > https://issues.apache.org/jira/browse/ATLAS-3344 > > > Repository: atlas > > > Description > ------- > > As of now Atlas metrics includes partition wise current offset and start > offset of Kafka topics. Include additional information like last message > processed time and failed message count. > > > Diffs > ----- > > > dashboardv2/public/js/templates/site/Statistics_Topic_Offset_table_tmpl.html > 4693edf > dashboardv2/public/js/templates/site/Statistics_tmpl.html ecd84d6 > dashboardv2/public/js/utils/Enums.js e38af74 > dashboardv2/public/js/views/site/Statistics.js a8e351e > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java a48d93b > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java > 2c78cbc > > > Diff: https://reviews.apache.org/r/71129/diff/2/ > > > Testing > ------- > > Tested mvn clean install package. > Some integration test cases which are not related to this patch are failing > on my local, not sure why. I'll look into those tests and fix them. > > Tested on cluster 172.22.88.47. > > > Thanks, > > Saqeeb Shaikh > >
