----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71276/#review217168 -----------------------------------------------------------
Fix it, then Ship it! addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java Lines 134 (patched) <https://reviews.apache.org/r/71276/#comment304444> Since no relationship attributes are to be included in this partial update, consider following - to avoid sending entityExtInfo in the notification: AtlasEntity renamedTableEntityForPartialUpdate = new AtlasEntity(renamedTableEntity.getEntity()); renamedTableEntityForPartialUpdate.setRelationshipAttributes(null); ... ret.add(new EntityPartialUpdateRequestV2(getUserName(), oldTableId, new AtlasEntityWithExtInfo(renamedTableEntityForPartialUpdate))); - Madhan Neethiraj On Aug. 13, 2019, 6:05 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71276/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2019, 6:05 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon > Rodrigues. > > > Bugs: ATLAS-3369 > https://issues.apache.org/jira/browse/ATLAS-3369 > > > Repository: atlas > > > Description > ------- > > create table table1(id int); #creates table1 entity (with guid = abc) > > alter table table1 rename to table2; > > > > table1 with guid "abc" is updated to table2 > > new table1 with guid "xyz" is created newly. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java > c59ff7fde > > > Diff: https://reviews.apache.org/r/71276/diff/1/ > > > Testing > ------- > > Manually tested with: > 1. Both hooks enabled - HMS and HS2. > 2. Only HMS hook enabled. > 3. Only HS2 hook enabled. > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1345/console > > > Thanks, > > Sarath Subramanian > >
