-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71294/#review217218
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On Aug. 15, 2019, 9:48 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71294/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2019, 9:48 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Sridhar K, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3374
>     https://issues.apache.org/jira/browse/ATLAS-3374
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - after an update to typesystem, the new type-registry wasn't initialized 
> with index-field-names for existing attributes, resulting in incorrect 
> population of search handler i.e. had an null entry
> - insufficient error handling cased the search handler to be populated with 
> incomplate index-field names, which caused incorrect search
> 
> 
> Diffs
> -----
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  113ea6c57 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 5c94c338f 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  8d8e4ad92 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
>  f337fb359 
> 
> 
> Diff: https://reviews.apache.org/r/71294/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that the search returns expected results for the failure cases 
> given in the JIRA
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1356/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to