[
https://issues.apache.org/jira/browse/ATLAS-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918344#comment-16918344
]
Bolke de Bruin edited comment on ATLAS-3393 at 8/29/19 7:12 AM:
----------------------------------------------------------------
I understand that backward compatibility is important. However, we encountered
this bug due to integration issues with our tooling expecting "createTime" as
it is used everywhere else[1]. I do think it will create more problems down the
road if you leave this inconstency in. "createTime" is also used hardcoded in
[2]. If it is considered to be an "internal" attribute what happens if you mix
the two? Is there a way to alias one to the other?
So the trade off is that this inconsistency needs to be tested for in
downstream tooling and it is not described in the documentation. So the
question becomes how much tooling is already integrating with "createtime" and
how much future tooling will assume "createTime". I think the latter will be
bigger.
[1] [https://github.com/apache/atlas/search?q=createTime&unscoped_q=createTime]
[2]
[https://github.com/apache/atlas/blob/7e4788ed00c6a0ef4e8c89f0486b8073a56409e4/intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java#L63]
was (Author: bolke):
I understand that backward compatibility is important. However, we encountered
this bug due to integration issues with our tooling expecting "createTime" as
it is used everywhere else[1]. I do think it will create more problems down the
road if you leave this inconstency in. "createTime" is also used hardcoded in
[2]. If it is considered to be an "internal" attribute what happens if you mix
the two? Is there a way to alias one to the other?
So the trade off is that this inconsistency needs to be tested for in
donwstream tooling and it is not described in the documentation. So the
question becomes how much tooling is already integrating with "createtime" and
how much future tooling will assume "createTime". I think the latter will be
bigger.
[1] [https://github.com/apache/atlas/search?q=createTime&unscoped_q=createTime]
[2]
[https://github.com/apache/atlas/blob/7e4788ed00c6a0ef4e8c89f0486b8073a56409e4/intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java#L63]
> Fix inconsistency with attribute createtime in aws_s3_bucket
> ------------------------------------------------------------
>
> Key: ATLAS-3393
> URL: https://issues.apache.org/jira/browse/ATLAS-3393
> Project: Atlas
> Issue Type: Bug
> Affects Versions: 1.2.0, 2.0.0
> Reporter: Bolke de Bruin
> Priority: Critical
>
> attributes are in camelcase. in aws_s3_bukcket createtime isnt
>
> (fix available in linked issue/pr)
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
