----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71409/ -----------------------------------------------------------
(Updated Aug. 29, 2019, 2:26 p.m.) Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3395 https://issues.apache.org/jira/browse/ATLAS-3395 Repository: atlas Description ------- When user logins in Atlas via TrustedProxy/KnoxSSO authentication method, the Atlas logout event does not functions as intended. Showing proper message on logout click will not cause any ambiguity to enduser. Diffs ----- dashboardv2/public/js/main.js 7b33da74d dashboardv2/public/js/utils/Utils.js 5274ef34c dashboardv2/public/js/views/site/Header.js b8ce4a8ad webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java f56aeb464 webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 8bac8c6f9 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java e78fcb61a webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java dff3d8d31 webapp/src/main/java/org/apache/atlas/web/security/AtlasWebAuthenticationDetails.java PRE-CREATION Diff: https://reviews.apache.org/r/71409/diff/1/ Testing (updated) ------- Tested on simple environment. Testing on Trusted Proxy enabled cluster is pending. Thanks, Nikhil Bonte