----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71439/#review217595 -----------------------------------------------------------
dashboardv2/public/js/utils/CommonViewFunction.js Line 19 (original), 19 (patched) <https://reviews.apache.org/r/71439/#comment304866> Get rid of trailing ','. dashboardv2/public/js/utils/CommonViewFunction.js Lines 758 (patched) <https://reviews.apache.org/r/71439/#comment304867> Is there any central logic for creating qualifiedNames? repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Line 413 (original), 413 (patched) <https://reviews.apache.org/r/71439/#comment304865> Remove commented code. - Ashutosh Mestry On Sept. 5, 2019, 12:36 p.m., Saqeeb Shaikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71439/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2019, 12:36 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3391 > https://issues.apache.org/jira/browse/ATLAS-3391 > > > Repository: atlas > > > Description > ------- > > When a term (with name T) belonging to glossary (G) is updated to (T1), its > qualified name does not gets updated. Search by term displays qualified names > of the terms, hence old name is seen there. The handling for updating > qualified name was present but since we were copying the qualified name from > the DB object, the handling code never got trigerred. > > This patch also includes required UI side changes. > > > Diffs > ----- > > dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 9229d2d > > > Diff: https://reviews.apache.org/r/71439/diff/1/ > > > Testing > ------- > > Manually tested by updating term and searching using the updated term > qualified name. > > > Thanks, > > Saqeeb Shaikh > >