-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71278/#review217600
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 906 (original), 906 (patched)
<https://reviews.apache.org/r/71278/#comment304872>

    Can you add this under an application property, say 
'atlas.relationships.warnOnNoRelationships'. That way you will be able to keep 
it turned ON for your implementations and others who are not interested will 
continue with same experience as before.


- Ashutosh Mestry


On Aug. 21, 2019, 7:42 p.m., Bolke de Bruin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71278/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2019, 7:42 p.m.)
> 
> 
> Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3368
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3368
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> If an entity is created that has a definition with a reference to a
>     non built in type, it will trigger a legacy code path in 
> EntityGraphMapper.
>     This path can take excessive amounts of time (>5s per commit), but 
> operators
>     can be caught unaware as the log message for this is at debug
>     level and explain the portential issue.
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  f9010fefb 
> 
> 
> Diff: https://reviews.apache.org/r/71278/diff/1/
> 
> 
> Testing
> -------
> 
> - reviewed patch logging to warn
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>

Reply via email to