> On Sept. 8, 2019, 8:24 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > > Line 1083 (original), 1063 (patched) > > <https://reviews.apache.org/r/71447/diff/4-5/?file=2164322#file2164322line1083> > > > > Shouldn't "value == INCOMPLETE_ENTITY_VALUE" be > > "value.equals(INCOMPLETE_ENTITY_VALUE)"?
yes, but it is safe to use '==' when value of integer is within the range -127 to 128 since Integer caches small integers. Anything out of this range will return false. I will change it to equals(). - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71447/#review217640 ----------------------------------------------------------- On Sept. 8, 2019, 4:22 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71447/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2019, 4:22 p.m.) > > > Review request for atlas, Sridhar K and Madhan Neethiraj. > > > Bugs: ATLAS-3405 > https://issues.apache.org/jira/browse/ATLAS-3405 > > > Repository: atlas > > > Description > ------- > > Hook notifications containing references to non-existing entities are dropped > by Atlas server, with the following error: > > AtlasObjectId{guid='null', typeName='hive_db', > uniqueAttributes={qualifiedName:db1@prod}} is not found > Instead of dropping such notifications, it will help to create an entity for > the reference, and complete processing of the notifications. Such entities > will only have its unique-attribute populated, however will capture the > lineage and other relationships. When Atlas receives details of the entity in > a subsequent notification, Atlas will have rest of the attributes populated > as well. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 673a85cb9 > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 9da51f516 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 659f7d586 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 26687bffc > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > a1776c843 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > a58c67059 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > 44df3512e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > c495dcc7a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 8ddbf748c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 02638c3ba > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java > fe76b3a89 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/UniqAttrBasedEntityResolver.java > d400a1df9 > server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > a844bcdf6 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > f7df6b38f > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java > 54f7330da > > > Diff: https://reviews.apache.org/r/71447/diff/5/ > > > Testing > ------- > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1386/console > > > Thanks, > > Sarath Subramanian > >
