> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 336 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line336> > > > > Like model builds, recommend adding an attribute for number of GPU's.
done > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 339 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line339> > > > > Would this be things like pod ID's? If we want to expose this kind of > > low-level, debugging information then let's make it complete enough to > > support most debugging use cases. > > > > For example, in order to take action based on the pod ID's, a cluster > > admin would need to know the k8s API server API, the kubeconfig, and the > > namespace in which the model is running. > > > > I think we could leave this field out for now, add an unstructured > > 'metadata' field and tackle the debugging flows later. I removed it > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 346 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line346> > > > > Should we add number of replicas? done > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 361 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line361> > > > > Should this be optional? it is removed > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 373 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line373> > > > > Is this for things like admin/full user/viewer only? If so, why make it > > non-optional? changed it to optional. I am thinking the type is admin/user, mlgov/service etc. > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 384-385 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line384> > > > > There currently is no such process in CML, projects are always created > > by user clicks in the UI. > > > > Oh, is this just here to define lineage relationships betwene users and > > projects? yes. The user is associated with a process, and the process creates a project. A user can have a lot of metadata. We don't want to duplicate the info to a project. > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 415 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line415> > > > > Same question about whether uniqueId should really be optional. removed. > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 442 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line442> > > > > The name above is just ml_project_create_process. This is relationship between ml_user and ml_project_create_process > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/1111-ml_model.json > > Lines 480 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line480> > > > > What's the reason for the ml_user prefix here and on > > ml_user_model_deploy_process? it is a relationship involves two types - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218231 ----------------------------------------------------------- On Oct. 16, 2019, 12:30 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2019, 12:30 a.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/1000-Hadoop/1111-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/1/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
