-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/
-----------------------------------------------------------
(Updated Oct. 18, 2019, 10:31 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
and Sarath Subramanian.
Changes
-------
Handled review comments, Added Base class "AtlasHTTPServlet" to incorporate
changes without using "if" clause.
Bugs: ATLAS-3472
https://issues.apache.org/jira/browse/ATLAS-3472
Repository: atlas
Description
-------
This patch uses Servlets instead of JSP files to render login and error page.
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java
PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java
PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java
PRE-CREATION
webapp/src/main/resources/spring-security.xml 1295244
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
webapp/src/main/webapp/error.html.template PRE-CREATION
webapp/src/main/webapp/error.jsp 29ef640
webapp/src/main/webapp/login.html.template PRE-CREATION
webapp/src/main/webapp/login.jsp 70ec06d
Diff: https://reviews.apache.org/r/71623/diff/3/
Changes: https://reviews.apache.org/r/71623/diff/2-3/
Testing
-------
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
Tested in browser with simple mode.
Tested in browser with Knox proxy on kerberos mode.
Thanks,
Mandar Ambawane
