----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218328 -----------------------------------------------------------
Minor comments. all related to attribute names. Please submit with the updated review request. addons/models/4000-MachineLearning/4010-ml_model.json Lines 46 (patched) <https://reviews.apache.org/r/71619/#comment305991> is it different from Name? addons/models/4000-MachineLearning/4010-ml_model.json Lines 63 (patched) <https://reviews.apache.org/r/71619/#comment305992> Can we change it to createTime for consistency with other entities. addons/models/4000-MachineLearning/4010-ml_model.json Lines 71 (patched) <https://reviews.apache.org/r/71619/#comment305993> Can we please change it to modifiedTime for consistency with other entities. addons/models/4000-MachineLearning/4010-ml_model.json Lines 179 (patched) <https://reviews.apache.org/r/71619/#comment305994> Same comment as above. In general, we want to have consistent name for similar attributes even if they are from different entities. So this comment applies to all createdAt and updatedAt attributes. addons/models/4000-MachineLearning/4010-ml_model.json Lines 206 (patched) <https://reviews.apache.org/r/71619/#comment305995> Let us call this as deployedTime. If you have time based attributes have names ending with "*Time" for consistency. - Sridhar K On Oct. 22, 2019, 3:42 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2019, 3:42 p.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/6/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
