----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71648/#review218338 -----------------------------------------------------------
addons/ml-hook-api/pom.xml Lines 25 (patched) <https://reviews.apache.org/r/71648/#comment306005> Should this inherit? addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/GovernanceHook.java Lines 40 (patched) <https://reviews.apache.org/r/71648/#comment306006> Do we need this? I don't foresee a solid use case for a "startup" in the hook. addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/HookContext.java Lines 48 (patched) <https://reviews.apache.org/r/71648/#comment306007> Why do we need a copy constructor? addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/MlMethodType.java Lines 25 (patched) <https://reviews.apache.org/r/71648/#comment306008> Do we need all of these? PUT, PATCH and DELETE enough? Why do we need a GET? - Karthik Manamcheri On Oct. 22, 2019, 4:49 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71648/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2019, 4:49 p.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, and Sarath Subramanian. > > > Bugs: atlas-3465 > https://issues.apache.org/jira/browse/atlas-3465 > > > Repository: atlas > > > Description > ------- > > define the hook API that ML governanace service will call after processing > its request > > > Diffs > ----- > > addons/ml-hook-api/pom.xml PRE-CREATION > > addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/GovernanceHook.java > PRE-CREATION > > addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/HookContext.java > PRE-CREATION > > addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/MlEntity.java > PRE-CREATION > > addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/MlEntityType.java > PRE-CREATION > > addons/ml-hook-api/src/main/java/org/apache/mlops/governance/hooks/MlMethodType.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71648/diff/1/ > > > Testing > ------- > > compilation passed > > > Thanks, > > Na Li > >
