----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218345 -----------------------------------------------------------
- please update AtlasTypesDef to add attribute: private List<AtlasNamespaceDef> namespaceDefs; intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 43 (patched) <https://reviews.apache.org/r/71649/#comment306021> namespaceAttributeDefs => attributeDefs intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 50 (patched) <https://reviews.apache.org/r/71649/#comment306022> Instead of passing 'null' for TypeCategory, please add NAMESPACE to TypeCategory and pass TypeCategory.NAMESPACE intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 60 (patched) <https://reviews.apache.org/r/71649/#comment306023> Le - use of "==" is correct here - this is to a simple optimization when the same object (this.namespaceAttributeDefs) is passed as the argument. intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 81 (patched) <https://reviews.apache.org/r/71649/#comment306024> insert this before #81: if (!super.equals(0)) { return false; } intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 83 (patched) <https://reviews.apache.org/r/71649/#comment306025> 'name' attribute will be handled in super.equals(). Replace #83 with the following: return Objects.equals(attributeDefs, that.attributeDefs); intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 88 (patched) <https://reviews.apache.org/r/71649/#comment306026> Objects.hash(getName()); => Objects.hash(super.hashCode(), attributeDefs); intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 131 (patched) <https://reviews.apache.org/r/71649/#comment306027> maxTextLength => maxStrLength patternText => validPattern intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 200 (patched) <https://reviews.apache.org/r/71649/#comment306028> insert the following before #200: if (!super.equals(o)) { return false; } intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 202 (patched) <https://reviews.apache.org/r/71649/#comment306029> replace #202 with: return Objects.equals(this.applicableEntityTypes, that.applicableEntityTypes) && Objects.equals(this.maxStrLength, that.maxStrLength) && Objects.equals(this.validPattern, that.validPattern); intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java Lines 232 (patched) <https://reviews.apache.org/r/71649/#comment306030> To be consistent with other classes, please move all getters/setters immediately after constructors. - Madhan Neethiraj On Oct. 22, 2019, 9:08 p.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71649/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2019, 9:08 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3486 > https://issues.apache.org/jira/browse/ATLAS-3486 > > > Repository: atlas > > > Description > ------- > > This change is the first part of the bigger task defined as part of > ATLAS-3485. > This adds the data model needed for supporting namespaces and namespace > attributes > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b870c4a300b41e93ee046b5f6d6b722728 > > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71649/diff/1/ > > > Testing > ------- > > Added unit tests > > > Thanks, > > Aadarsh Jajodia > >
