----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71689/#review218428 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java Lines 658 (patched) <https://reviews.apache.org/r/71689/#comment306139> reorder to list public methods first and then private methods. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 353 (patched) <https://reviews.apache.org/r/71689/#comment306140> update this line to use => setLabels(vertex, getLabelString(updatedLabels)); nit: add new line after 352 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 366 (patched) <https://reviews.apache.org/r/71689/#comment306141> nit: add new line after 365 - Sarath Subramanian On Oct. 28, 2019, 2:23 p.m., Le Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71689/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2019, 2:23 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3483 > https://issues.apache.org/jira/browse/ATLAS-3483 > > > Repository: atlas > > > Description > ------- > > The current implementation of label only exposes setLabel endpoint to users. > setLabel will replace the existing labels with labels passed in with > function. It would be nice to have the enhancement to support add labels to > existing label and, delete label. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > a986520a9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 17b4a5b9d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > f07cff1a8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 19d4cef3d > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > d95c12762 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5f7d3339 > > > Diff: https://reviews.apache.org/r/71689/diff/2/ > > > Testing > ------- > > - Added tests, passed. > - will run pre-commit job. > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1503/console > > > Thanks, > > Le Ma > >
