-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71694/
-----------------------------------------------------------

(Updated Oct. 29, 2019, 10:06 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, Mandar Ambawane, Nikhil Bonte, Nixon Rodrigues, Sameer 
Shaikh, and Sidharth Mishra.


Changes
-------

addressed review comments.


Bugs: ATLAS-3498
    https://issues.apache.org/jira/browse/ATLAS-3498


Repository: atlas


Description
-------

Update basic-search to enable search using labels


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
8f0e5912d 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
03eb92bcc 
  
repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java 
3f58acb9c 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
7ad32bdb9 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
b56d8e83a 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
173165a28 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 7853dc15c 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
bb1e9f633 
  repository/src/test/java/org/apache/atlas/utils/SearchPredicateUtilTest.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 908ae7033 
  webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
808f62354 
  webapp/src/test/resources/hive-db-50-tables.zip 
fe29f5726e4c180bee42084576d43f0447453be8 
  webapp/src/test/resources/json/search-parameters/combination-filters.json 
dc52d33d1 
  webapp/src/test/resources/json/search-parameters/entity-filters.json 
93d2d7d36 
  webapp/src/test/resources/json/search-parameters/tag-filters.json 5e74328d6 


Diff: https://reviews.apache.org/r/71694/diff/2/

Changes: https://reviews.apache.org/r/71694/diff/1-2/


Testing
-------

Precommit: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1505/console

Added unit tests to test basic search with labels for (entity, classification 
and fulltext)


Thanks,

Sarath Subramanian

Reply via email to