----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218640 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 163 (patched) <https://reviews.apache.org/r/71649/#comment306444> it will be useful to include namespace name and attribute name in the error message. intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 27 (patched) <https://reviews.apache.org/r/71649/#comment306443> nit: unused import intg/src/test/java/org/apache/atlas/TestUtilsV2.java Lines 1466 (patched) <https://reviews.apache.org/r/71649/#comment306457> defineNamespaceTypesDef() is never used. please review repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java Lines 559 (patched) <https://reviews.apache.org/r/71649/#comment306454> preDeleteByGuid() and preDeleteByName() may not be needed. Please review. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 253 (patched) <https://reviews.apache.org/r/71649/#comment306447> preDeleteByName() and preDeleteByGuid() may not be needed. We will not be deleting any reference edges from the namespaceDef vertex (since no edges exists). repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 264 (patched) <https://reviews.apache.org/r/71649/#comment306446> this is not valid. NamespaceDef should be deleted only when no entity has reference to that namespace name. Maybe check if there are any entity referring this namespace (using index query?) before deleting. Same for line #294 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 311 (patched) <https://reviews.apache.org/r/71649/#comment306450> toNamespaceDef => toAtlasNamespaceDef repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 321 (patched) <https://reviews.apache.org/r/71649/#comment306451> toNamespaceDef => toAtlasNamespaceDef repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 382 (patched) <https://reviews.apache.org/r/71649/#comment306449> toJsonFromAttribute => toJsonFromNamespaceAttribute repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 420 (patched) <https://reviews.apache.org/r/71649/#comment306448> toAttributeDefFromJson => toNamespaceAttributeDefFromJson repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 421 (patched) <https://reviews.apache.org/r/71649/#comment306452> AtlasBaseException is never thrown repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java Lines 524 (patched) <https://reviews.apache.org/r/71649/#comment306453> we may need to check for NamespaceAttributeDef with empty/null 'applicableTypes' => CollectionUtils.isEmpty(attributeDef.getApplicableEntityTypes()) repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java Lines 697 (patched) <https://reviews.apache.org/r/71649/#comment306455> empty test? webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Lines 22 (patched) <https://reviews.apache.org/r/71649/#comment306456> nit: review unused imports - Sarath Subramanian On Nov. 13, 2019, 4:08 p.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71649/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2019, 4:08 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3486 > https://issues.apache.org/jira/browse/ATLAS-3486 > > > Repository: atlas > > > Description > ------- > > This change is the first part of the bigger task defined as part of > ATLAS-3485. > This adds the data model needed for supporting namespaces and namespace > attributes and also updates the type registry to include the applicable > namespace attributes for every entity type > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > 7a2aae2e9ae8174c5309164f3e41c940cbf3ddf8 > intg/src/main/java/org/apache/atlas/model/TypeCategory.java > f06f64f450f407e3f9a0e742726ff4dd12ccc695 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b870c4a300b41e93ee046b5f6d6b722728 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java > 3634fdfd313639eb97b3c4698e091487b0e44a80 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java > 4ee68a936f99bb4c819b5335da2cc8bf7d539397 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 884447f81c57faf917a8d0565fc0a0c7ebbd99f0 > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java > 8b4fd1c3b9005d0a8852f2828475b4ad6a806822 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java > 0883d54f490e22c6510e6fc0cb804b87713a7ecb > intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java > dba2d88146eff314191ae6bb24ad7337b0ea10ae > intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java > 02613b5f7250b14324ed294c22de079b74d55b08 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java > 530d5cda44b7d3746f5cb8dd5a23b3c68b254cac > > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 2e2ab1a664171555c57560e1c0b4cbdbc20c0f6f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java > a5ccfb5b2055c88f596312f4033bc0034d3d165c > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > 51dd16b8518c9a16088547f3e95c0ef401695895 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java > 6cd0ee331b7ae24757b58e76ec47bf556106846a > > > Diff: https://reviews.apache.org/r/71649/diff/4/ > > > Testing > ------- > > Added unit tests > > > Thanks, > > Aadarsh Jajodia > >
