----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71818/#review218812 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Line 539 (original), 541 (patched) <https://reviews.apache.org/r/71818/#comment306693> This file has only whitespace changes. Consider reverting changes in this file. intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java Lines 130 (patched) <https://reviews.apache.org/r/71818/#comment306694> Namespace attributes are part of AtlasEntity, and validation of namespace attributes should be performed in AtlasEntityType. Please review. repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 1079 (patched) <https://reviews.apache.org/r/71818/#comment306695> Namespace attributes should be treated as regular entity attributes, in store/retrieval from graph-store i.e. each attribute should be stored in a separate property. The code here suggests that all namespace attributes are stored in a map. This doesn't sound right. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java Lines 99 (patched) <https://reviews.apache.org/r/71818/#comment306696> Validation of namespace attributes should be handled in the call to AtlasEntityType.validateValue() at #97 above. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java Lines 128 (patched) <https://reviews.apache.org/r/71818/#comment306697> Validation of namespace attributes should be handled in the call to AtlasEntityType.validateValueForUpdate() at #126 above. - Madhan Neethiraj On Nov. 26, 2019, 2:04 a.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71818/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2019, 2:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3534 > https://issues.apache.org/jira/browse/ATLAS-3534 > > > Repository: atlas > > > Description > ------- > > The changes made in these include adding/updating namespaces to an entity > instance > as part of create or update > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java > 0b28243c47d9e025ecc38a05ce1a54efd71e6149 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > 7a2aae2e9ae8174c5309164f3e41c940cbf3ddf8 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 1b033b9ac0d413c04269b480562940fb5b305939 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 557ef74a95c2a939b4b89cd1db8fa4c73d52dd51 > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 1e7acf1e728f472a01a26fe4be69a11e21ca3e77 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > d3d9367fb158f2bafbcc44f3c25ee1a63c5c2aa7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > c8e65ef15fcf38cb4b5f1d9f1f37cf1578c13b48 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > a114d252e7462a08c14ebef598ed13b6b43e247b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 6b111732a11b2aef7dbeb050087bde3c70fd21bd > > > Diff: https://reviews.apache.org/r/71818/diff/1/ > > > Testing > ------- > > > Thanks, > > Aadarsh Jajodia > >
