-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71841/#review218866
-----------------------------------------------------------


Ship it!




Ship It!

- Bolke de Bruin


On Nov. 27, 2019, 9:43 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71841/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2019, 9:43 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3261
>     https://issues.apache.org/jira/browse/ATLAS-3261
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Adam Rempter (arempter) provided the patch for this improvement in 
> https://github.com/apache/atlas/pull/58#issuecomment-514541803. This review 
> has further updates - to cache user-authencation for configured amount of 
> time (5 minutes by default), to reduce the performance impact of generating 
> authentication object from username.
> 
> 
> Diffs
> -----
> 
>   pom.xml b2506e70e 
>   webapp/pom.xml 57cab62a3 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  41a6c2eff 
> 
> 
> Diff: https://reviews.apache.org/r/71841/diff/1/
> 
> 
> Testing
> -------
> 
> - manual verification of authorization based on username in notification 
> message
> - successful UT, IT runs
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to