-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71482/
-----------------------------------------------------------
(Updated Dec. 9, 2019, 12:42 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
and Sarath Subramanian.
Bugs: ATLAS-3423
https://issues.apache.org/jira/browse/ATLAS-3423
Repository: atlas
Description
-------
This patch consists implementation for 2 end points first for template download
and other for csv file upload with term details also the Unit Test cases for
both the end points.
* The 1st endpoint {glossary/template} return template file this would be type
of format of data that shows how the data needs to be populated by user in the
file.
http://localhost:21000/api/atlas/v2/glossary/importHeaderRow
Template structure:-
GlossaryName, TermName, ShortDescription, LongDescription, Examples,
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor,
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms,
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
Fruits,Apple5,SD4,LD4,"EXAMPLE","ABBREVIATION","USAGE",,"Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4","Footwear:B4"
* The 2nd endpoint {glossary/importGlossaryData} (file upload) would actually
parse the Data into AtlasObjects and further create the AtlasGlossaryTerms
inside Glossary.
curl -v -g POST -u admin:admin -H "Content-Type: multipart/form-data" -H
"Cache-Control: no-cache" -F file=@template_6.csv
"http://localhost:21000/api/atlas/v2/glossary/import
Note:-
While populating the data in the csv file each record should be maintained in
single Line (enter command within the record would result in parsing the second
line as a new record).
The downloaded template needs to be saved as whateverTheFileNameIs.csv
explicitly.
If the file is been succefully uploaded then the AtlasGlossaryTerm would be
returned or else List of Errors would returned for user to rectify them further.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 0b28243
dashboardv2/gruntfile.js 174d67f
dashboardv2/package-lock.json 168ea11
dashboardv2/package.json dd6f9a5
dashboardv2/public/css/scss/theme.scss 0589e09
dashboardv2/public/index.html.tpl a6a999e
dashboardv2/public/js/main.js 6ba1e12
dashboardv2/public/js/templates/glossary/GlossaryLayoutView_tmpl.html 1fa1e35
dashboardv2/public/js/templates/glossary/ImportGlossaryLayoutView_tmpl.html
PRE-CREATION
dashboardv2/public/js/utils/UrlLinks.js 4e98c41
dashboardv2/public/js/views/glossary/GlossaryLayoutView.js c8cda4f
dashboardv2/public/js/views/glossary/ImportGlossaryLayoutView.js PRE-CREATION
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 979bd0a
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7a2aae2
intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java
660514b
pom.xml eb2689f
repository/pom.xml 802d587
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
9229d2d
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
cdc3f07
repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 9625f94
repository/src/main/java/org/apache/atlas/util/FileUtils.java PRE-CREATION
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
be1698f
repository/src/test/resources/csvFiles/empty.csv PRE-CREATION
repository/src/test/resources/csvFiles/incorrectFile.csv PRE-CREATION
repository/src/test/resources/csvFiles/template_1.csv PRE-CREATION
repository/src/test/resources/excelFiles/template_1.xlsx PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 151aa6b
Diff: https://reviews.apache.org/r/71482/diff/9/
Changes: https://reviews.apache.org/r/71482/diff/8-9/
Testing
-------
Tested both the endpoint with curl call.
Tested upload term csv with around 100 records from curl.
Thanks,
mayank jain
