----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72069/#review219475 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 126 (patched) <https://reviews.apache.org/r/72069/#comment307640> - consider renaming IGNORE_RELATIONSHIP_ATTRIBUTES to ENTITY_CHANGE_NOTIFY_IGNORE_RELATIONSHIP_ATTRIBUTES, in EntityGraphMapper and AtlasConfiguration. - also, consider updating the property name "atlas.ignore.relationship.attributes.for.entity.get.and.cache" to "atlas.entity.change.notify.ignore.relationship.attributes" - Madhan Neethiraj On Feb. 3, 2020, 8:55 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72069/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2020, 8:55 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, > mayank jain, Nixon Rodrigues, and Sidharth Mishra. > > > Bugs: ATLAS-3602 > https://issues.apache.org/jira/browse/ATLAS-3602 > > > Repository: atlas > > > Description > ------- > > Provide option to Ignore relationship attribute mapping in getAndCacheEntity() > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 6e726f25b > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java > 01e339d23 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > e427a59e7 > > > Diff: https://reviews.apache.org/r/72069/diff/3/ > > > Testing > ------- > > Manually validated and perf improvement seen during add/delete classifications > > > Thanks, > > Sarath Subramanian > >
