-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72128/#review219571
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 1866 (original), 1867 (patched)
<https://reviews.apache.org/r/72128/#comment307759>

    Consider replacing call to PropertiesUtil.getBooleanProperty() with an 
entry in AtlasConfiguration:
    
    - class AtlasConfiguration {
        ...
        
CLASSIFICATION_PROPAGATION_DEFAULT("atlas.classification.propagation.default", 
true),
        ...
      }
    
    - class EntityGraphMapper {
        ...
        boolean static boolean CLASSIFICATION_PROPAGATION_DEFAULT = 
AtlasConfiguration.CLASSIFICATION_PROPAGATION_DEFAULT.getBoolean();
        ...
    
    - line #1867:
        propagateTags = CLASSIFICATION_PROPAGATION_DEFAULT;


- Madhan Neethiraj


On Feb. 13, 2020, 9:43 a.m., Mandar Ambawane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72128/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2020, 9:43 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-3614
>     https://issues.apache.org/jira/browse/ATLAS-3614
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Read classification-propagation value from property file
> 
> 
> Diffs
> -----
> 
>   distro/src/conf/atlas-application.properties 7846452 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  113325d 
> 
> 
> Diff: https://reviews.apache.org/r/72128/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Reply via email to