----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72174/#review219691 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java Lines 458 (patched) <https://reviews.apache.org/r/72174/#comment307908> Pinal - good to see addition of 'NOT_CONTAINS' operator! I suggest to use a separate patch for this enhancement. Please review if UI updates are necessary for addition of this new operator; for example, the list of operators shown in UI depends on the type of attribute. - Madhan Neethiraj On Feb. 28, 2020, 12:04 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72174/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2020, 12:04 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3600 > https://issues.apache.org/jira/browse/ATLAS-3600 > > > Repository: atlas > > > Description > ------- > > System Attributes does not support following 4 search , > > classification search > Propogated Classification Search > User-Defined Attributes > Labels > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > c74cf5122 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 356363db0 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > bb1e9f633 > > > Diff: https://reviews.apache.org/r/72174/diff/1/ > > > Testing > ------- > > Tested all above 4 system attributes manually. > > > Thanks, > > Pinal Shah > >
