----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/ -----------------------------------------------------------
(Updated March 6, 2020, 5:37 a.m.) Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes ------- Rebase patch Bugs: ATLAS-3618 https://issues.apache.org/jira/browse/ATLAS-3618 Repository: atlas Description ------- 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected Diffs (updated) ----- repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java ebd5992cd repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java b5ede0b82 Diff: https://reviews.apache.org/r/72156/diff/4/ Changes: https://reviews.apache.org/r/72156/diff/3-4/ Testing ------- 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal) 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result Usecase: -> Added, term1 in Glossary -> added classification1 to term1 1) In search Panel(showing all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah