----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72224/#review219895 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java Lines 107 (patched) <https://reviews.apache.org/r/72224/#comment308138> can we reuse isPropagate() ? if its serialization issue consider changing all references of isPropagate() to getPropagate() - Sarath Subramanian On March 11, 2020, 12:05 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72224/ > ----------------------------------------------------------- > > (Updated March 11, 2020, 12:05 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Mehul Parikh, Nixon > Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3614 > https://issues.apache.org/jira/browse/ATLAS-3614 > > > Repository: atlas > > > Description > ------- > > - added configuration atlas.classification.propagation.default, which decides > propagation when 'propagate' flag is not specified during addition of a > classification > - default value is 'true' i.e. added classficaion will be propagated when > 'propagate' flag is now specified > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5bf50dca > intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java > 0d20622f4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > d3ba18f38 > > > Diff: https://reviews.apache.org/r/72224/diff/1/ > > > Testing > ------- > > verified manually that this the default specified in the configuration is > used while adding a classification if 'propage' flag is not specified > > > Thanks, > > Madhan Neethiraj > >
