----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72235/#review219958 -----------------------------------------------------------
Ship it! Ship It! - Nikhil Bonte On March 13, 2020, 9:56 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72235/ > ----------------------------------------------------------- > > (Updated March 13, 2020, 9:56 p.m.) > > > Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3663 > https://issues.apache.org/jira/browse/ATLAS-3663 > > > Repository: atlas > > > Description > ------- > > **Approach** > *new* DataMigrationStatusService: Creates a vertex specific to the migration. > Manages the vertex during the lifetime of the migration. Uses _indexQuery_ > for quick retrieval. > *modified* ZipFileMigrationImporter: Consume the new service. Displays > appropriate log messages. > *modified* EntityCreationManager: To consume the new position returned by the > service. > *modified* EntityConsumer: Update last known good position. > > The position is maintained across server restarts. On successful completion, > the vertex is deleted. > > **Status REST API** > This API now reflects migration status: > ``` > http://amestryb-2.gce.cloudera.com:31000/api/atlas/admin/status > ``` > > Output: > ``` > {"Status":"MIGRATING","MigrationStatus":{"startTime":1584135451790,"currentIndex":44584,"currentCounter":0,"totalCount":6211055,"name":"/tmp/atlas-data/file-to-import-atlas.zip"}} > ``` > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java > 09dafdf24 > > intg/src/main/java/org/apache/atlas/model/migration/MigrationImportStatus.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/pc/StatusReporter.java f84e8d00f > intg/src/test/java/org/apache/atlas/pc/StatusReporterTest.java 3e5056267 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > c18c4ab68 > > repository/src/main/java/org/apache/atlas/repository/impexp/MigrationProgressService.java > 54ae32a01 > > repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationStatusService.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java > 35a76ea3d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java > 4c912fdbe > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java > e8f4b02a0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java > 16bb49e86 > > repository/src/test/java/org/apache/atlas/repository/impexp/DataMigrationStatusServiceTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72235/diff/4/ > > > Testing > ------- > > **Unit tests** > New tests added. > > **REST API** > Verified. > > **Pre-commit** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1736/ > > > Thanks, > > Ashutosh Mestry > >
