----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72280/#review220100 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Line 116 (original), 108 (patched) <https://reviews.apache.org/r/72280/#comment308405> Wouldn't line #108 cause index-search to be not used when no attribute filter is specified? For example, when the search filter has only classification name? repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Lines 111 (patched) <https://reviews.apache.org/r/72280/#comment308406> buildTraitPredict() doesn't handle wildcards in the classification-name - like classificationName="*PII". Please review. - Madhan Neethiraj On March 30, 2020, 5:50 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72280/ > ----------------------------------------------------------- > > (Updated March 30, 2020, 5:50 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3703 > https://issues.apache.org/jira/browse/ATLAS-3703 > > > Repository: atlas > > > Description > ------- > > Example of cases where Filters of classification doesn't work > ClassificationType + Classification Filter + Term > ClassificationType + Classification Filter + Text > EntityType + Entity Filter + ClassificationType + Classification Filter + Term > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 1343c9b96 > > > Diff: https://reviews.apache.org/r/72280/diff/1/ > > > Testing > ------- > > Manually tested all above cases, except case where attributes are non indexed > > > Thanks, > > Pinal Shah > >
