> On March 30, 2020, 10:14 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 1300 (patched) > > <https://reviews.apache.org/r/72278/diff/2/?file=2216459#file2216459line1306> > > > > The following cases are not handled: > > > > |-----------------------| > > | currValue | newValue | > > |-----------------------| > > | Null | Null | => Will set to empty map > > | Empty | Null | => Will set to empty map > > | Not Null | Null | => Will set to empty map > > |-----------------------| > > > > Please review.
Remember to add unit tests for these cases as well. - Karthik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/#review220127 ----------------------------------------------------------- On March 30, 2020, 9:45 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72278/ > ----------------------------------------------------------- > > (Updated March 30, 2020, 9:45 p.m.) > > > Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K, and > Sarath Subramanian. > > > Bugs: atlas-3700 > https://issues.apache.org/jira/browse/atlas-3700 > > > Repository: atlas > > > Description > ------- > > 1) The model definition is in > "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90"; > > 2) I created a request of type EntityCreateRequestV2. It contains an entity > of type ml_model_build with an attribute "metadata", which is a map, and > contains key-value entries for "engineImageTag" and "engineImageName". > > 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains > an entity of type ml_model_build with an attribute "metadata", which is a > map, and contains key-value entry for "updated_at". > > 4) In the properties of the entity ml_model_build, the * attribute > "*metadata" only contains key-value entry for "updated_at". > > Desired behavior: > > The attribute "metadata" should contains key-value entries for > "engineImageTag", "engineImageName" and "updated_at". > > Current behavior: > > the attribute "metadata" only contains key-value entry for "updated_at". > > > Diffs > ----- > > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 1434a24590c4f4172378f98d83ca8d9e9ec9c4d8 > > intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java > 5b5fa04e26b17071bdc2160974d7005bc110de74 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 75b016cca04801c4c1512c1527453fd59a11a6c4 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > 225b72cbef20b2329b36f550da60c1bbe1f95efa > server-api/src/main/java/org/apache/atlas/RequestContext.java > 282a66f1d466d58bce7a590513bc92f99733ba81 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 3f1ea05e17cded3433d050f891c807d55bdd022a > > > Diff: https://reviews.apache.org/r/72278/diff/3/ > > > Testing > ------- > > add new test case for map attribute for partial update > > > Thanks, > > Na Li > >
