----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/#review220248 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java Lines 1000 (patched) <https://reviews.apache.org/r/72317/#comment308579> code duplicated. Try to combine with for loop above for 'ttr.getAllEntityTypes()' line #984 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java Lines 214 (patched) <https://reviews.apache.org/r/72317/#comment308580> code duplicated. Try to use 'changedTypeDefs' to include 'changedBusinessMetadataDefs' - Sarath Subramanian On April 6, 2020, 11:20 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72317/ > ----------------------------------------------------------- > > (Updated April 6, 2020, 11:20 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3709 > https://issues.apache.org/jira/browse/ATLAS-3709 > > > Repository: atlas > > > Description > ------- > > Resolved issues in conjunction with Business Metadata attributes. > Also handled index populate for Business Metadata attributes at the time of > start up. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 647e304 > > > Diff: https://reviews.apache.org/r/72317/diff/1/ > > > Testing > ------- > > Pre-commit > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console > > Manual testing done. > > CASE:1 > 1. create Busines meatadata "BM1" > 2. add one attribute "attr1" in "BM1" (search weight 9) > 3. create one entity "hdfsentity1" > 4. associate "attr1" to "hdfsentity1" > 5. check in quick search and suggestions for "attr1" value > > 6. add another attribute "attr2" in "BM1" (search weight 9) > 7. associate "attr2" to "hdfsentity1" > 8. check in quick search and suggestions > > > CASE:2 > 1. create Busines meatadata "BM1" > 2. add one attribute "attr1" in "BM1" (search weight 9) > 3. create one entity "hdfsentity1" > 4. associate "attr1" to "hdfsentity1" > 5. check in quick search and suggestions for "attr1" value > > 6. add another attribute "attr2" in "BM1" (search weight 10) > 7. associate "attr2" to "hdfsentity1" > 8. check in quick search and suggestions for "attr1" and "attr2" values > > > CASE:3 > 1. create Busines meatadata "BM1" > 2. add one attribute "attr1" in "BM1" (search weight 9) > 3. create one entity "hdfsentity1" > 4. associate "attr1" to "hdfsentity1" > 5. check in quick search and suggestions for "attr1" value > > 6. create another Busines meatadata "BM2" > 7. add attribute "attr2" in "BM2" (search weight 9) > 8. associate "attr2" to "hdfsentity1" > 9. check in quick search and suggestions for "attr1" and "attr2" values > > > Thanks, > > Mandar Ambawane > >
