----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72338/#review220271 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On April 9, 2020, 11:26 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72338/ > ----------------------------------------------------------- > > (Updated April 9, 2020, 11:26 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3726 > https://issues.apache.org/jira/browse/ATLAS-3726 > > > Repository: atlas > > > Description > ------- > > Added a new field for result count at model, Changed the DTO and service > accordingly. UT has been modified too. Now sort and filter will also work on > top of result count in admin audit > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json 351e07bd3 > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > f2a8b3e4d > > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java > 590f7a034 > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasAuditEntryDTO.java > 8e4bdb523 > > repository/src/test/java/org/apache/atlas/repository/audit/AdminPurgeTest.java > 0a2fc39a3 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 9bc70400e > > > Diff: https://reviews.apache.org/r/72338/diff/2/ > > > Testing > ------- > > Manual Testing: > > curl --location --request POST > 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audits/' > \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \ > --data-raw '{ > "auditFilters": { > "condition": "AND", > "criterion": [ > { > "attributeName": "userName", > "operator": "like", > "attributeValue": "admin" > }, > { > "attributeName": "operation", > "operator": "like", > "attributeValue": "PURGE" > }, > { > "attributeName": "clientId", > "operator": "eq", > "attributeValue": "10.96.94.236" > }, > { > "attributeName": "startTime", > "operator": "gte", > "attributeValue": "1575958152162" > }, > { > "attributeName": "endTime", > "operator": "gte", > "attributeValue": "1575958152184" > }, > { > "attributeName": "resultCount", > "operator": "eq", > "attributeValue": "4" > } > ] > }, > "limit": 15, > "offset": 0, > "sortBy": "resultCount", > "sortOrder": "DESCENDING" > }' > > > Thanks, > > Sidharth Mishra > >
