----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72372/#review220336 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java Lines 95 (patched) <https://reviews.apache.org/r/72372/#comment308662> ATTRIBUTE_NAME_INVALID: this error code is about use of a restricted-keyword for attribute name. ATTRIBUTE_NAME_INVALID(400, "ATLAS-400-00-020", "{0}: invalid name. Attribute name must not contain query keywords") I suggest to create a new error code for this case: ATTRIBUTE_NAME_INVALID_CHARS(400, "ATLAS-400-00-09A", "{0}: invalid name. Attribute names must begin with a letter followed by a sequence of letters, numbers, or '_' characters") - Madhan Neethiraj On April 16, 2020, 2:19 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72372/ > ----------------------------------------------------------- > > (Updated April 16, 2020, 2:19 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3695 > https://issues.apache.org/jira/browse/ATLAS-3695 > > > Repository: atlas > > > Description > ------- > > ATLAS-3695 [Business Metadata] Special characters are being allowed in > Attribute Name > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java > 5f4136f > > > Diff: https://reviews.apache.org/r/72372/diff/1/ > > > Testing > ------- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1815/console > > Basic testing is done. > > > Thanks, > > Mandar Ambawane > >
