----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72396/#review220402 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 21, 2020, 11:54 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72396/ > ----------------------------------------------------------- > > (Updated April 21, 2020, 11:54 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3746 > https://issues.apache.org/jira/browse/ATLAS-3746 > > > Repository: atlas > > > Description > ------- > > typename = hive_table > > classification = _NOT_CLASSIFIED > > fetches right results. > > But > > just classification = _NOT_CLASSIFIED > > doesn't fetch any results. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java > 3f58acb9c > > > Diff: https://reviews.apache.org/r/72396/diff/1/ > > > Testing > ------- > > Tested below combination manually > > 1) classification = _NOT_CLASSIFIED -> working > 2) typeName = hive_table, classification = _NOT_CLASSIFIED -> working > 3) typeName = hive_table, Entity Filters, classification = _NOT_CLASSIFIED -> > working > 4) typeName = hive_table, classification = _NOT_CLASSIFIED, > classificationFilters -> **results will not show up because classification > filter on _NOT_CLASSIFIED classification doesn't make sense** > 5) classification = _NOT_CLASSIFIED, classificationFilters -> **results will > not show up because classification filter on _NOT_CLASSIFIED classification > doesn't make sense** > > > Thanks, > > Pinal Shah > >
