----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72411/#review220405 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Line 465 (original), 465 (patched) <https://reviews.apache.org/r/72411/#comment308787> consider using @PUT with body of guids instead of guids in QueryParam, you are restricted with the number of guids you can supply in the query params (url length is limited). Reference: GlossaryRest:disassociateTermAssignmentFromEntities() - Sarath Subramanian On April 21, 2020, 1:22 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72411/ > ----------------------------------------------------------- > > (Updated April 21, 2020, 1:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3747 > https://issues.apache.org/jira/browse/ATLAS-3747 > > > Repository: atlas > > > Description > ------- > > ATLAS-3747: Atlas Admin Purge API should take list of guids as query param > instead of body > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 5a19a0b0e > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > a7d554a36 > > > Diff: https://reviews.apache.org/r/72411/diff/1/ > > > Testing > ------- > > Manual Testing: > curl -u admin:admin123 --location --request DELETE > 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/?guid=82785128-778a-4e0d-aac0-8327b4ca1e87&guid=f0cc9cfd-71af-47fc-9321-2970dfa5825f&guid=f0cc9cfd-71af-47fc-9321-2970dfa5825f' > --header 'Content-Type: application/json' > > Note: As local jetty was failing for couple of times, I was not able to run > EntityV2JerseyResourceIT. precommit run will ensure if this passes. > > > Thanks, > > Sidharth Mishra > >
