----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72450/#review220552 -----------------------------------------------------------
Mandar - UI already caches type-def details, to render in the left-hand side pane. UI should be able to find the service-type from its typedef cache. I suggest to not introduce AtlasEntityHeader.serviceType field to address this need. - Madhan Neethiraj On April 29, 2020, 12:24 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72450/ > ----------------------------------------------------------- > > (Updated April 29, 2020, 12:24 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3763 > https://issues.apache.org/jira/browse/ATLAS-3763 > > > Repository: atlas > > > Description > ------- > > Added "serviceType" in AtlasEntityHeader, so from UI > https://issues.apache.org/jira/browse/ATLAS-3366 this can be handled > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 7d2476a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 757fcb1 > > > Diff: https://reviews.apache.org/r/72450/diff/1/ > > > Testing > ------- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1856/console > > > Thanks, > > Mandar Ambawane > >
