----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72458/#review220580 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java Lines 162 (patched) <https://reviews.apache.org/r/72458/#comment309062> for clarity, I suggest the following: void processIndexStringAttributes(AtlasVertex vertex, AtlasEntityType entityType) { for (AtlasAttribute attribute : entityType.getAllAttributes().values()) { if (AtlasAttributeDef.IndexType.STRING.equals(attribute.getIndexType()) { ... } } } void processUniqueAttributes(AtlasVertex vertex, AtlasEntityType entityType) { for (AtlasAttribute attribute : entityType.getUniqAttributes().values()) { .. } } - Madhan Neethiraj On May 1, 2020, 4:31 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72458/ > ----------------------------------------------------------- > > (Updated May 1, 2020, 4:31 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3773 > https://issues.apache.org/jira/browse/ATLAS-3773 > > > Repository: atlas > > > Description > ------- > > **Approach** > Please refer to JIRA for details. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java > 2b5811919 > > > Diff: https://reviews.apache.org/r/72458/diff/1/ > > > Testing > ------- > > **Manual verification** > Steps: > - Imported dataset from 0.8 using migration import. > - Let the patch handlers run. > - Verified DSL queries and basic search functionality. > > **Pre-commit** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1862/ > > > Thanks, > > Ashutosh Mestry > >
