-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72464/
-----------------------------------------------------------
(Updated May 3, 2020, 4:04 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
and Sidharth Mishra.
Bugs: ATLAS-3778
https://issues.apache.org/jira/browse/ATLAS-3778
Repository: atlas
Description
-------
When deleting a classification, we remove the following properties from entity
vertex and update these properties with the classification name removed.
PROPAGATED_TRAIT_NAMES_PROPERTY_KEY
TRAIT_NAMES_PROPERTY_KEY
This will be an expensive operation during commit time when dealing with large
number of classifications. This improvement will only remove the deleted
classification name from both the above property keys and the commit foot print
will be less.
Diffs (updated)
-----
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
4af39eded
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusElement.java
a9cc5a6ce
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
5643599a4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
5564bc59a
Diff: https://reviews.apache.org/r/72464/diff/2/
Changes: https://reviews.apache.org/r/72464/diff/1-2/
Testing
-------
Manually tested on delete classification with 400 classifications associated to
entity.
Performance improvement seen from 19 mins to 29 secs
Thanks,
Sarath Subramanian
